Add Intl to Crash Message Component.#2990
Merged
chrisgarrity merged 1 commit intoscratchfoundation:developfrom Aug 31, 2018
Merged
Add Intl to Crash Message Component.#2990chrisgarrity merged 1 commit intoscratchfoundation:developfrom
chrisgarrity merged 1 commit intoscratchfoundation:developfrom
Conversation
Contributor
Author
|
Could someone please give me insight about the failing test? I ran the suite multiple times at local but it seems that it fails randomly. |
Contributor
|
@Wgil Sorry about that! It was a temporary error, re-running the tests fixed it. |
chrisgarrity
approved these changes
Aug 31, 2018
Contributor
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
@Wgil thanks for this change! Sorry it took so long to finish the review - I had to figure out a way to get the editor to crash :)
Contributor
Author
|
@chrisgarrity You're welcome! :) I rendered the component through dev tools :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Allows Crash Message Component to be translated.
Reason for Changes
The text in the component was a string literal.
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet