[Develop] Split BrowserModalComponent out of GUI#2994
Merged
thisandagain merged 7 commits intodevelopfrom Sep 6, 2018
Merged
Conversation
[Master] Roll back x/y rounding
Release August 24 to Beta
Contributor
Author
|
Try it out: hotfix/fix-browser-modal I'm a bot, not actually @rschamp! |
Deploy to Master
If the VM is ever instantiated, which happens whenever GUI is instantiated due to default props, then IE11 will crash
rschamp
force-pushed
the
hotfix/fix-browser-modal
branch
from
884e419 to
58b2b76
Compare
added 2 commits
September 5, 2018 11:52
Removing this was the point of moving the test up one level. Thanks @chrisgarrity, good catch!
thisandagain
approved these changes
Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2993