Mirror the speaker icon for RTL languages#3022
Merged
chrisgarrity merged 1 commit intoscratchfoundation:developfrom Aug 30, 2018
Merged
Mirror the speaker icon for RTL languages#3022chrisgarrity merged 1 commit intoscratchfoundation:developfrom
chrisgarrity merged 1 commit intoscratchfoundation:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
This mirrors the speaker icon for RTL languages.
Since the library and sprite selector components are not aware of which kind of content being displayed the
scaleX(-1)css trick doesn't work because it would mirror all the sprite costumes as well as the sound icon.Instead the sound components provide an alternate (rtl) version of the icon for the image url.
Test Coverage
Try it: https://chrisgarrity.github.io/scratch-gui/issue/2983-mirror-speaker/?locale=he
Please show how you have added tests to cover your changes
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet