Fix sprite-info pane for ‘wide’ languages#3225
Merged
chrisgarrity merged 1 commit intoscratchfoundation:developfrom Oct 4, 2018
Merged
Fix sprite-info pane for ‘wide’ languages#3225chrisgarrity merged 1 commit intoscratchfoundation:developfrom
chrisgarrity merged 1 commit intoscratchfoundation:developfrom
Conversation
Move the labels above the inputs for languages that don’t fix in the width of the sprite-info pane. Because of the different widths of everything I left aligned them. Examples, Abkhaz, Catalan, Greek. renamed the `rtl-locales` lib file as `locale-utils` as it’s doing more than rtl now. RTL should probably move into the scratch-l10n repo, but should the `wide-locales` setting? That seems like something that is gui specific. I don’t like having to hard code the specific languages that don’t fit, but there didn’t seem to be a better way to handle it right now.
thisandagain
approved these changes
Oct 4, 2018
Contributor
thisandagain
left a comment
thisandagain
left a comment
There was a problem hiding this comment.
Looks good! Tested in Safari and Chrome. Thanks @chrisgarrity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Move the labels above the inputs for languages that don’t fit in the width of the sprite-info pane.
Examples,
Abkhaz, Catalan, Greek...
renamed the
rtl-localeslib file aslocale-utilsas it’s doing more than rtl now. RTL should probably move into the scratch-l10n repo, but should thewide-localessetting? That seems like something that is gui specific. I don’t like having to hard code the specific languages that don’t fit, but there didn’t seem to be a better way to handle it right now.I left aligned the labels as it seemed to look better most of the time. They are middle aligned horizontally - does that make sense? /cc @carljbowman
Reason for Changes
The translations of the sprite-info labels in some languages end up being too wide for the fixed width of the sprite-info pane. When this happens the stage info gets pushed off the screen.
Test Coverage
Manually tested, current tests still run. It would probably be good to have someone else also look through all the languages to make sure I didn't miss any that should be in the 'wide' set.
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet