Fix expensive operation in mapStateToProps#3250
Merged
fsih merged 2 commits intoscratchfoundation:developfrom Oct 3, 2018
Merged
Fix expensive operation in mapStateToProps#3250fsih merged 2 commits intoscratchfoundation:developfrom
fsih merged 2 commits intoscratchfoundation:developfrom
Conversation
chrisgarrity
suggested changes
Oct 3, 2018
Contributor
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
Just one picky detail. I did run it and everything worked for me.
fsih
force-pushed
the
fixGetCostumeInMapStateToProps
branch
from
e64d090 to
ea4e339
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Fixes #3235
Proposed Changes
Move getCostume() out of mapStateToProps. mapStateToProps is called any time the state changes, and getCostume can be very expensive because it has to decode from storage. In addition, I added a shouldComponentUpdate to ignore the props that don't affect rendering.
Reason for Changes
Projects could run very slowly when the paint editor was open
Test Coverage
Tested Space Giraffe and Geometry Dash
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet