Skip to content

Use defineMessages #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisgarrity merged 1 commit into from
Oct 3, 2018
Merged

Use defineMessages #3257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions src/components/preview-modal/preview-modal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,21 @@ const messages = defineMessages({
defaultMessage: 'Welcome to the Scratch 3.0 Beta',
description: 'Header for Preview Info Modal',
id: 'gui.previewInfo.welcome'
},
notNowTooltip: {
defaultMessage: 'Not Now',
description: 'Tooltip for Not Now button',
id: 'gui.previewModal.notnowtooltip'
},
tryItTooltip: {
defaultMessage: 'Try It',
description: 'Tooltip for Try It button',
id: 'gui.previewModal.tryittooltip'
},
viewProjectTooltip: {
defaultMessage: 'View 2.0 Project',
description: 'Tooltip for View 2.0 Project button',
id: 'gui.previewModal.viewprojecttooltip'
}
});

Expand Down Expand Up @@ -52,11 +67,7 @@ const PreviewModal = ({intl, ...props}) => (
<Box className={styles.buttonRow}>
<button
className={styles.noButton}
title={intl.formatMessage({
defaultMessage: 'Not Now',
description: 'Tooltip for Not Now button',
id: 'gui.previewModal.notnowtooltip'
})}
title={intl.formatMessage(messages.notNowTooltip)}
onClick={props.onCancel}
>
<FormattedMessage
Expand All @@ -67,11 +78,7 @@ const PreviewModal = ({intl, ...props}) => (
</button>
<button
className={styles.okButton}
title={intl.formatMessage({
defaultMessage: 'Try It',
description: 'Tooltip for Try It button',
id: 'gui.previewModal.tryittooltip'
})}
title={intl.formatMessage(messages.tryItTooltip)}
onClick={props.onTryIt}
>
<FormattedMessage
Expand All @@ -90,11 +97,7 @@ const PreviewModal = ({intl, ...props}) => (
</button>
<button
className={styles.viewProjectButton}
title={intl.formatMessage({
defaultMessage: 'View 2.0 Project',
description: 'Tooltip for View 2.0 Project button',
id: 'gui.previewModal.viewprojecttooltip'
})}
title={intl.formatMessage(messages.viewProjectTooltip)}
onClick={props.onViewProject}
>
<FormattedMessage
Expand Down