Use defineMessages#3257
Merged
chrisgarrity merged 1 commit intoscratchfoundation:developfrom Oct 3, 2018
Merged
Conversation
Contributor
|
@apple502j it looks good - I'll run all the scripts on Monday to check the execution. Thanks! |
chrisgarrity
approved these changes
Oct 3, 2018
Contributor
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
Thanks @apple502j it all works great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
#3252
Proposed Changes
Change preview modal to use defineMessages
Reason for Changes
To fix mistakes I did in past PRTo make preview modal tooltips translatable by translators