handle many modes of new project creation by benjiwheeler · Pull Request #3391 · scratchfoundation/scratch-gui

benjiwheeler · 2018-10-17T07:25:59Z

Needs scratchfoundation/scratch-www#2197 to work

Handles several states in which the user should be able to create a new project:

standalone player/beta: file->new just replaces current project data with default data
in www, logged in, viewing your project: file->new saves your project, replaces current project data with default data, then saves that data and gets a new id, then informs containing code of the change
in www, logged in, viewing someone else’s project: file->new replaces current project data with default data, then saves that data and gets a new id, then informs containing code of the change
in www, not logged in, viewing whatever project: file->new replaces current project data with default data, then informs containing code of the change
in www, logged in, clicking “create” from front page; or, going straight to projects/editor: loads default data, then saves that data and gets a new id, then informs containing code of the change
in www, not logged in, clicking “create” from front page: loads default data
After Attach flyout listeners to GUI workspace #4, when you log in or register while still in the editor, saves current data and gets a new id, then informs containing code of the change

And, one state in which the project should be automatically saved:
8. User creates a project; then logs out. Later, the user opens project in editor; makes changes; realizes isn't logged in, so logs in; project should automatically save.

rschamp

Tests are failing

src/containers/sb-file-uploader.jsx

 }

 SBFileUploader.propTypes = {
+    canSave: PropTypes.bool, // eslint-disable-line react/no-unused-prop-types


src/containers/gui.jsx

-    componentWillReceiveProps (nextProps) {
-        if (this.props.projectTitle !== nextProps.projectTitle) {
-            this.props.onUpdateReduxProjectTitle(nextProps.projectTitle);
+    setReduxTitle (newTitle) {


src/lib/project-saver-hoc.jsx

 import storage from '../lib/storage';
 import {
    LoadingStates,
+    canNowCreateNew,


src/lib/project-saver-hoc.jsx

+            if (this.props.canSave && this.props.isShowingWithoutId &&
+                (!prevProps.canSave || !prevProps.isShowingWithoutId)) {
+                // create the project
+                this.props.canNowCreateNew();


src/containers/gui.jsx

+    }
+    componentDidUpdate (prevProps) {
+        if (this.props.projectId !== prevProps.projectId && this.props.projectId !== null) {
+            this.props.onUpdateProjectId(this.props.projectId);


src/reducers/project-state.js

-const DONE_LOADING_VM_NEW_DEFAULT = 'scratch-gui/project-state/DONE_LOADING_VM_NEW_DEFAULT';
-const DONE_LOADING_VM_NEW_DEFAULT_TO_SAVE = 'scratch-gui/project-state/DONE_LOADING_VM_NEW_DEFAULT_TO_SAVE';
-const DONE_LOADING_VM_FILE_UPLOAD = 'scratch-gui/project-state/DONE_LOADING_VM_FILE_UPLOAD';
+const DONE_LOADING_VM_WITHOUT_ID = 'scratch-gui/project-state/DONE_LOADING_VM_WITHOUT_ID';


src/reducers/project-state.js

    ERROR: null,
    FETCHING_WITH_ID: null,
    FETCHING_NEW_DEFAULT: null,
-    FETCHING_NEW_DEFAULT_TO_SAVE: null,


src/reducers/project-state.js

        }
        return state;
-    case DONE_LOADING_VM_NEW_DEFAULT:
+    case DONE_LOADING_VM_TO_CREATE:


src/reducers/project-state.js

            type: DONE_LOADING_VM_WITH_ID
        };
    case LoadingState.LOADING_VM_FILE_UPLOAD:
+        if (canSave) {


responding to canSave without needing canSaveNew prop removed canSaveNew added default for onUpdateProjectId removed conflict files erroneously added don't pass down onError got tests passing better creating and saving logic and names

benjiwheeler · 2018-10-19T11:09:02Z

Rebased on top of develop and added the changes to project-saver-hoc that we discussed. Also removed the unused action from project-state reducer, and added tests for project-saver-hoc.

rschamp

Tests are still failing.

src/containers/gui.jsx

src/reducers/project-state.js

        }
        return state;
-    case DONE_LOADING_VM_NEW_DEFAULT:
+    case DONE_LOADING_VM_TO_CREATE:


src/lib/project-saver-hoc.jsx

 import storage from '../lib/storage';
 import {
    LoadingStates,
+    canNowCreateNew,


src/lib/project-saver-hoc.jsx

test/unit/util/project-saver-hoc.test.jsx

benjiwheeler self-assigned this Oct 17, 2018

benjiwheeler added the pr - changes requested label Oct 17, 2018

benjiwheeler force-pushed the create-new-project branch from 92c9228 to d3494b4 Compare October 17, 2018 15:01

benjiwheeler assigned benjiwheeler and rschamp and unassigned benjiwheeler Oct 17, 2018

benjiwheeler added pr - needs review and removed pr - changes requested labels Oct 17, 2018

benjiwheeler removed their assignment Oct 17, 2018

benjiwheeler mentioned this pull request Oct 17, 2018

Pass to and receive from GUI info about project creation lifecycle; handle url changes scratchfoundation/scratch-www#2197

Merged

benjiwheeler changed the title ~~handle three modes of new project creation~~ handle many modes of new project creation Oct 17, 2018

benjiwheeler mentioned this pull request Oct 17, 2018

embedded gui should respond when enclosing environment changes the projectId it passes in #3386

Closed

rschamp assigned benjiwheeler and unassigned rschamp Oct 18, 2018

rschamp added pr - changes requested and removed pr - needs review labels Oct 18, 2018

rschamp suggested changes Oct 18, 2018

View reviewed changes

benjiwheeler commented Oct 18, 2018

View reviewed changes

benjiwheeler assigned rschamp and unassigned benjiwheeler Oct 18, 2018

benjiwheeler added pr - needs review and removed pr - changes requested labels Oct 18, 2018

benjiwheeler force-pushed the create-new-project branch 3 times, most recently from 18f1530 to 1d218ad Compare October 18, 2018 20:01

handle many modes of new project creation

b0c4bee

responding to canSave without needing canSaveNew prop removed canSaveNew added default for onUpdateProjectId removed conflict files erroneously added don't pass down onError got tests passing better creating and saving logic and names

benjiwheeler force-pushed the create-new-project branch from 1d218ad to b0c4bee Compare October 18, 2018 21:46

rschamp suggested changes Oct 19, 2018

View reviewed changes

rschamp added the pr - changes requested label Oct 19, 2018

rschamp removed the pr - needs review label Oct 19, 2018

rschamp assigned benjiwheeler and unassigned rschamp Oct 19, 2018

added one more vm-manager-hoc.test fix

37e2bf3

rschamp previously approved these changes Oct 19, 2018

View reviewed changes

rschamp added pr - good to merge and removed pr - changes requested labels Oct 19, 2018

rschamp added this to the October 2018 milestone Oct 19, 2018

removed commented out test

f9780fb

benjiwheeler dismissed rschamp’s stale review via f9780fb October 19, 2018 14:19

rschamp mentioned this pull request Oct 19, 2018

Refactor IntlProvider in GUI to support integration with www #3431

Merged

13 tasks

benjiwheeler merged commit 5b3e7c6 into scratchfoundation:develop Oct 19, 2018

benjiwheeler deleted the create-new-project branch October 19, 2018 20:01

This was referenced Oct 19, 2018

Logged in user can create new project, with new id #3352

Closed

Ability to "load" new 3.0 project #2954

Closed

Conversation

benjiwheeler commented Oct 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rschamp left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

benjiwheeler commented Oct 19, 2018

Uh oh!

rschamp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

benjiwheeler commented Oct 17, 2018 •

edited

Loading