Restore IntlProvider for Internet Explorer #3532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GUI includes its own Intl provider (react-intl supports nested intl providers) that works within the www intl provider. Restore the app-state provider intl provider and app-stat-hoc for the stand-alone gui so that IE can function enough to put up the unsupported browser.
Contributor
|
@rschamp @benjiwheeler could you review this? I'm not familiar with the context from #3431 but you two reviewed that one. |
Contributor
|
This LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #3431 GUI includes its own Intl provider (react-intl supports nested intl providers) that works within the www intl provider.
This PR restores the app-state-hoc intl provider for the stand-alone gui so that IE can function enough to put up the unsupported browser.
This will permit adding localization to things outside what's exported by GUI. We should be very careful about adding localization to any GUI wrapper component because it will work in playground (because of this PR), but possibly break in www.