Skip to content

Conversation

@paulkaplan
Copy link
Contributor

@paulkaplan paulkaplan commented Dec 13, 2018

Resolves

What Github issue does this resolve (please include link)?

Proposed Changes

Describe what this Pull Request does

If you aren't on the tutorial project, open it in a new tab in a way that'll work in production

@ericrosenbaum
Copy link
Contributor

hmm, travis is failing in a way that may be legit, on "Load a project by ID directly through url"

@benjiwheeler
Copy link
Contributor

LMK if you want me to take a look at the overlap with project-state

@paulkaplan
Copy link
Contributor Author

@ericrosenbaum that is suspicious, although it is running locally for me, so I'm going to rerun it. The code changes were only in the tips library, so although project loading is involved, none of that code should be being touched.

@paulkaplan
Copy link
Contributor Author

@ericrosenbaum confirmed that was a problem with project server, not us.

I also implemented a confirm to prevent you from leaving a project with unsaved changes. It isn't great, but I figure anything is better than losing work.

@paulkaplan paulkaplan force-pushed the more-beefers branch 2 times, most recently from 23bcaa9 to 8954b6e Compare December 18, 2018 20:21
@paulkaplan
Copy link
Contributor Author

@chrisgarrity this can be reviewed now. It keeps the window opening behavior, but changes it to open the project at /projects/<project id>?tutorial=<tutorial id>. Note that this wont work in staging due to missing project, but works in prod

Copy link
Contributor

@chrisgarrity chrisgarrity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little change: the new URL should open the editor.

Copy link
Contributor

@chrisgarrity chrisgarrity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I uploaded a copy of the project to my local copy. Replacing the project id with the one on my local one worked great.

@paulkaplan paulkaplan merged commit b5b3f33 into scratchfoundation:develop Dec 19, 2018
@paulkaplan paulkaplan deleted the more-beefers branch December 19, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle required project for a tutorial in a better way

4 participants