Skip to content

Show error ID if available from Raven and report react errors#4151

Merged
paulkaplan merged 1 commit intoscratchfoundation:developfrom
paulkaplan:show-error-id
Dec 19, 2018
Merged

Show error ID if available from Raven and report react errors#4151
paulkaplan merged 1 commit intoscratchfoundation:developfrom
paulkaplan:show-error-id

Conversation

@paulkaplan
Copy link
Contributor

/cc @rschamp @colbygk this does two things:

  1. Show the relevant error ID to the user if Raven is available.
  2. Report react errors to raven in the error boundary.

I will need to add this to the error boundary in www as well.

Copy link
Contributor

@rschamp rschamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rschamp rschamp assigned paulkaplan and unassigned rschamp Dec 19, 2018
@paulkaplan paulkaplan merged commit 9b3c847 into scratchfoundation:develop Dec 19, 2018
@paulkaplan paulkaplan deleted the show-error-id branch December 19, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants