Fix delete button on sprite tiles#4376
Merged
paulkaplan merged 3 commits intoscratchfoundation:developfrom Jan 17, 2019
Merged
Conversation
paulkaplan
changed the title
The previous change that made the images laid out using absolute meant that the close button was layered below the sprite image, making it now clickable
paulkaplan
force-pushed
the
fix-delete-button
branch
from
2d2dea9 to
cc81cc7
Compare
Contributor
|
LGTM, tested and delete buttons on sprites and costumes are visible and usable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug I introduced in #4362, by putting an absolutely positioned image above the "close" button that deletes sprites.
I fixed the issue and added an integration test. Previous integration tests only tested the right-click -> delete sprite for some reason.