Migrate scratch-gui to GitHub Actions #9330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delasare
force-pushed
the
gha-migration
branch
from
83369da
to
b9c5d28
Compare
- add setup - cache dependencies and dependency outputs - add build job - add unit test job - add integration test job - add npm deploy - add gh pages deploy
delasare
force-pushed
the
gha-migration
branch
from
83223c2
to
c983032
Compare
delasare
force-pushed
the
gha-migration
branch
from
2d15b55
to
9282eea
Compare
delasare
force-pushed
the
gha-migration
branch
from
5ebba30
to
7251656
Compare
| @@ -14,7 +14,6 @@ | |||
| "build": "npm run clean && webpack --colors --bail", | |||
| "clean": "rimraf ./build && mkdirp build && rimraf ./dist && mkdirp dist", | |||
| "deploy": "touch build/.nojekyll && gh-pages -t -d build -m \"[skip ci] Build for $(git log --pretty=format:%H -n1)\"", | |||
| "prepare": "husky install", | |||
cwillisf
requested changes
Nov 15, 2023
| if: github.ref_name == 'develop' | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| cache: "npm" |
There was a problem hiding this comment.
I believe this line tells the setup-node action to cache the npm package cache, so the "Cache node_modules" item further down shouldn't be necessary
There was a problem hiding this comment.
Oh, never mind. I see now that you're using those cache items to carry files to the other jobs.
.github/workflows/ci-cd.yml
Outdated
| GitHub head ref: ${{ github.head_ref }} | ||
| EOF | ||
| - name: Install Dependencies | ||
| run: npm install |
There was a problem hiding this comment.
Suggested change
| run: npm install | |
| run: npm ci |
.github/workflows/ci-cd.yml
Outdated
Comment on lines
122
to
123
| - name: Run Build | ||
| run: npm run build |
There was a problem hiding this comment.
Suggested change
| - name: Run Build | |
| run: npm run build | |
| - name: Run Build | |
| env: | |
| NODE_ENV: production | |
| run: npm run build |
Comment on lines
+175
to
+176
| echo Installed chromium version: ${{ steps.setup-chrome.outputs.chrome-version }} | ||
| ${{ steps.setup-chrome.outputs.chrome-path }} --version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
https://scratchfoundation.atlassian.net/browse/ENG-11