Skip to content
This repository was archived by the owner on Jun 19, 2018. It is now read-only.

Added doAsk and answer prims #18

Closed
wants to merge 4 commits into from
Closed

Added doAsk and answer prims #18

wants to merge 4 commits into from

Conversation

alyssarosenzweig
Copy link

No description provided.

@alyssarosenzweig
Copy link
Author

@lightnin Could you merge this?

@lightnin
Copy link
Contributor

lightnin commented Nov 1, 2013

No, Shane is the code expert here. He'll need to review and ok it first. It may take him a bit, but he'll get to it :) Just be patient.

@alyssarosenzweig
Copy link
Author

@lightnin K, sorry, impatient xD

I noticed you merge blob's instructions and falsely assumed you were the project maintainer.

@sclements
Copy link
Contributor

Hi @bobbybee would you mind putting the CSS into player.css instead of in the code?

@alyssarosenzweig
Copy link
Author

@sclements No problem! I'll do that now.

@alyssarosenzweig
Copy link
Author

@sclements Done.

@alyssarosenzweig
Copy link
Author

@sclements I believe this is ready for merging, no?

@nathan
Copy link
Contributor

nathan commented Nov 2, 2013

Please use four spaces for indentation. The rest of the JS source has been using it since 6360de0.

@alyssarosenzweig
Copy link
Author

@nathandinsmore

First two are fixed, and quite frankly, I'm not sure how to change my editors indentation preferences.

@nathan
Copy link
Contributor

nathan commented Nov 2, 2013

@bobbybee what editor do you use?

@alyssarosenzweig
Copy link
Author

TextMate

@nathan
Copy link
Contributor

nathan commented Nov 2, 2013

Also, did you forget to push? I don't see any new commits.

@alyssarosenzweig
Copy link
Author

Ah, found it!

@nathan
Copy link
Contributor

nathan commented Nov 2, 2013

  • The UI doesn't match that of the Flash player
  • The bubble doesn't have a blue outline
  • The prompt doesn't disappear when you click the stop button.

@brianpilati
Copy link
Contributor

@nathan This can be closed based on #43. Thanks @bobbybee for the jumpstart. Your work on blocking for a response saved me a lot of time.

@tmickel tmickel closed this Sep 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants