Export the sprite and return an add function when deleting the sprite.#1438
Merged
kchadha merged 2 commits intoscratchfoundation:developfrom Aug 9, 2018
Merged
Conversation
kchadha
force-pushed
the
return-add-sprite-function-when-deleting
branch
from
cf0bc9d to
5ef246a
Compare
9 tasks
Contributor
|
It would be nice to have tests however |
…Funciton should return a promise.
Contributor
Author
|
@rschamp, just added an integration test for restoring a deleted sprite. This also uncovered a subtle bug where the restoreFunction returned by the deleteSprite function was not returning the promise of adding the sprite back. |
Contributor
|
Thank you! |
rschamp
approved these changes
Aug 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Towards the 'Restore' functionality for restoring deleted sprites. Export a sprite before deleting it and return a function to add that sprite back.
Test Coverage
Manual testing.
Related PRs
scratchfoundation/scratch-gui#1438