Restore sound #1503
Merged
Restore sound #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
kchadha
commented
Aug 20, 2018
| /** | ||
| * Delete a sound from the current editing target. | ||
| * @param {int} soundIndex - the index of the sound to be removed. | ||
| * @return {?Function} A function to restore the sound that was deleted, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kchadha
commented
Aug 20, 2018
| return null; | ||
| } | ||
| // Delete the sound at the given index | ||
| const deletedSound = this.sprite.sounds.splice(index, 1)[0]; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rschamp
approved these changes
Aug 21, 2018
test/unit/sprites_rendered-target.js
Outdated
| const firstDeleted = a.deleteSound(0); | ||
| t.deepEqual(a.sprite.sounds, [o2, o3]); | ||
| t.type(firstDeleted, 'object'); | ||
| t.equals(firstDeleted.id, 1); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| return null; | ||
| } | ||
| // Delete the sound at the given index | ||
| const deletedSound = this.sprite.sounds.splice(index, 1)[0]; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| /** | ||
| * Delete a sound from the current editing target. | ||
| * @param {int} soundIndex - the index of the sound to be removed. | ||
| * @return {?Function} A function to restore the sound that was deleted, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Towards restoring a deleted sound.
Proposed Changes
Deleting a sound returns a function to restore the deleted sound.
Reason for Changes
Restore sound feature.
Test Coverage
Added new unit test for vm.deleteSound and updated a unit test for rendered-target.deleteSound.
Related PRs
scratchfoundation/scratch-gui#2935