Fix issue with uploading default vector image #1864
Merged
kchadha merged 1 commit intoscratchfoundation:developfrom Dec 21, 2018
Merged
Fix issue with uploading default vector image #1864kchadha merged 1 commit intoscratchfoundation:developfrom
kchadha merged 1 commit intoscratchfoundation:developfrom
Conversation
…en image was not correctly setting the costume's md5.
fsih
approved these changes
Dec 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves scratchfoundation/scratch-www#2534
Proposed Changes
Fix issue introduced by #1840 where replacing a broken image with the default vector image from storage was not updating the costume's md5. This causes an error for subsequent project loads when trying to load a project with this fix that was saved on the server.
Test Coverage
Tested #2534
cc/ @benjiwheeler, @ktbee