Add PROJECT_RUN_START/STOP events#348
Merged
rschamp merged 4 commits intoscratchfoundation:developfrom Nov 28, 2016
Merged
Conversation
added 2 commits
November 23, 2016 15:43
These events signal when any threads are running or when all threads have stopped running. This maps to whether the green flag or the stop button should be illuminated in the GUI.
tmickel
reviewed
Nov 24, 2016
src/engine/runtime.js
Outdated
| this.redrawRequested = false; | ||
| var inactiveThreads = this.sequencer.stepThreads(); | ||
| this._updateGlows(inactiveThreads); | ||
| this._setThreadCount(this.threads.length); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Contributor
|
LGTM other than the one comment about thread-counting. Thanks for cleaning up stuff! |
Also rename inactiveThreads -> doneThreads, since this describes them better. They are the threads that have completed in the step.
tmickel
approved these changes
Nov 28, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These events signal when any threads are running or when all threads have stopped running. This maps to whether the green flag or the stop button should be illuminated in the GUI.
I also cleaned up some inconsistencies in the other glow code since I was in there:
Runtime.SCRIPT_GLOW_ON/OFFnow maps to'SCRIPT_GLOW_ON/OFF'not'STACK_GLOW_ON/OFF'VISUAL_REPORTnow emits an object from Runtime, just like VirtualMachine does.