-
Notifications
You must be signed in to change notification settings - Fork 902
break word in project description #3599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
break word in project description #3599
Conversation
chrisgarrity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok, but note that word-break: break-word is deprecated in favor of overflow-wrap: break-word: https://developer.mozilla.org/en-US/docs/Web/CSS/word-break. Assuming it solves the problem it would be better to use the non-deprecated solution.
|
Looks like it's
Seems from some research ( https://stackoverflow.com/questions/1795109/what-is-the-difference-between-word-break-break-all-versus-word-wrap-break ) like it would make sense to include both. @chrisgarrity Take a look at my change! |
chrisgarrity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree, the word-break: break-word option is specifically deprecated in favor of overflow wrap. The word-break css was trying to handle two situations: languages where each glyph may be a word, and wrapping exceedingly long words in other languages that overflow their container. overflow-wrap is the correct way to handle the latter. Are there browsers that we need to support that don't support the overflow-wrap version so it's necessary for us to have both?
Oh, I see, you're right. Removing! |
chrisgarrity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Resolves:
Resolves #2853
Changes:
Implements the fix that @Smrman proposed in #2853 (comment) , which is to apply the
word-break: break-wordstyle to theproject-descriptionclass.Screenshots:
Chrome:
Before:
After:
Firefox:
Before: (narrow window size):
After: (narrow window size):
Safari:
Before:
After: