Skip to content

Conversation

@benjiwheeler
Copy link
Contributor

Resolves:

Resolves #2853

Changes:

Implements the fix that @Smrman proposed in #2853 (comment) , which is to apply the word-break: break-word style to the project-description class.

Screenshots:

Chrome:

Before:

image

After:

image

Firefox:

Before: (narrow window size):

image

After: (narrow window size):

image

Safari:

Before:

image

After:

image

Copy link
Contributor

@chrisgarrity chrisgarrity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, but note that word-break: break-word is deprecated in favor of overflow-wrap: break-word: https://developer.mozilla.org/en-US/docs/Web/CSS/word-break. Assuming it solves the problem it would be better to use the non-deprecated solution.

@benjiwheeler
Copy link
Contributor Author

benjiwheeler commented Dec 17, 2019

Looks like it's word-wrap that is deprecated in favor of overflow-wrap -- the former is currently an alias for the latter.

work-break is something different, apparently.

Seems from some research ( https://stackoverflow.com/questions/1795109/what-is-the-difference-between-word-break-break-all-versus-word-wrap-break ) like it would make sense to include both.

@chrisgarrity Take a look at my change!

Copy link
Contributor

@chrisgarrity chrisgarrity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree, the word-break: break-word option is specifically deprecated in favor of overflow wrap. The word-break css was trying to handle two situations: languages where each glyph may be a word, and wrapping exceedingly long words in other languages that overflow their container. overflow-wrap is the correct way to handle the latter. Are there browsers that we need to support that don't support the overflow-wrap version so it's necessary for us to have both?

@benjiwheeler
Copy link
Contributor Author

I disagree, the word-break: break-word option is specifically deprecated in favor of overflow wrap.

Oh, I see, you're right. Removing!

Copy link
Contributor

@chrisgarrity chrisgarrity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benjiwheeler benjiwheeler merged commit 08386bf into scratchfoundation:develop Dec 18, 2019
@benjiwheeler benjiwheeler deleted the instructions-word-break branch December 30, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text overflow in project Notes and Credits

2 participants