move country name lookup to library #3974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwillisf
approved these changes
Jun 16, 2020
Contributor
cwillisf
left a comment
cwillisf
left a comment
There was a problem hiding this comment.
Looks good!
My one quibble would be that the function names aren't very consistent: lookupCountryInfo looks up a country info object by its two-letter code and lookupCountryName looks up a country info object by its name, which means one function is named for its return type (and could be the name of either function) and the other is named for its argument. If I remember correctly the current lookupCountryInfo is called from quite a few places, though, so renaming that might be too "noisy" to make sense as part of this change. I don't think this is a blocking issue, just a small item of low-interest tech debt.
Contributor
Author
|
Thanks for the suggestion! I revised this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor as follow-up to #3856
Moves country code lookup logic into the country data library