Skip to content

Conversation

@benjiwheeler
Copy link
Contributor

@benjiwheeler benjiwheeler commented Jun 12, 2020

hotfix version of PR #4095 which resolves https://github.com/LLK/scratchr2/issues/5723

Test plan:

Already tested on staging:

  1. create new account
  2. confirm that opt in field does not appear in form
  3. confirm that account creation works
  4. confirm that email confirmation works
  5. confirm that sharing a project works

For production, we should repeat these steps.

We should also confirm that the email address was not added to our Mailchimp list.

@benjiwheeler benjiwheeler added this to the June 2020 milestone Jun 12, 2020
@benjiwheeler benjiwheeler self-assigned this Jun 12, 2020
@benjiwheeler benjiwheeler merged commit 1f1a8f1 into master Jun 15, 2020
@benjiwheeler
Copy link
Contributor Author

Update: tested in production using the steps listed above. Confirmed that the new user is not in the Mailchimp user list.

@benjiwheeler benjiwheeler deleted the hotfix/remove-opt-in branch June 15, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants