Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add rangeKey for event #99

Merged
merged 1 commit into from
Dec 19, 2016
Merged

fix: add rangeKey for event #99

merged 1 commit into from
Dec 19, 2016

Conversation

minzcmu
Copy link
Member

@minzcmu minzcmu commented Dec 19, 2016

  • datastore-sequelize's scan method will set the sortKey for the index type, which is null now. This will cause error when querying the database.
  • Change the sortKey to createTime

https://github.com/screwdriver-cd/datastore-sequelize/blob/master/index.js#L327

petey
petey approved these changes Dec 19, 2016
View reviewed changes
Copy link
Contributor

@petey petey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh. 👍

grumpy_cat_found_her_boyfriend_at_disneyland

@petey petey merged commit 8fcb910 into master Dec 19, 2016
@petey petey deleted the sql branch December 19, 2016 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petey petey petey approved these changes

@stjohnjohnson stjohnjohnson stjohnjohnson approved these changes

Assignees
No one assigned
Labels
change/patch priority/medium review/with team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minzcmu @petey @stjohnjohnson