feat(3197): Table cell component for stages in pipeline list jobs view #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
force-pushed
the
stageForJobsListView
branch
from
bb931e6
to
1561875
Compare
VonnyJap
reviewed
Nov 13, 2024
| import { computed } from '@ember/object'; | ||
|
|
||
| export default Component.extend({ | ||
| stageName: computed('record.stage.stageName', { |
There was a problem hiding this comment.
Locally I got an error when viewing something without a stage.
There was a problem hiding this comment.
There was a problem hiding this comment.
After some investigation, this issue is caused when a pipeline has jobs that never run before, the change to the jobs list view to include the stages is not able to handle this at the moment.
To reproduce: create any new pipeline and don't run any builds, check into the jobs list view and console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The new jobs UI makes use of custom components for each cell in the table. This creates a new component for handling the stage name for the job.
Objective
Create a glimmer component for the jobs.
V1:
V2:
References
screwdriver-cd/screwdriver#3197
screwdriver-cd/screwdriver#3200
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.