Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3171): Pull in latest data-schema to persist pipeline template workflowGraph in a new column #55

Merged

Conversation

sagar1312
Copy link
Member

@sagar1312 sagar1312 commented Aug 29, 2024

BREAKING CHANGE: Move workflowGraph out of config and keep it at the same level as config

Context

Changes were made in screwdriver-cd/data-schema#571 (and related PRs) to store workflowGraph of pipeline template as part of the config

Objective

Move workflowGraph out of config and keep it at the same level as config

References

screwdriver-cd/screwdriver#3171

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

package.json Outdated
@@ -46,7 +46,7 @@
},
"dependencies": {
"@hapi/hoek": "^10.0.1",
"screwdriver-data-schema": "^23.1.0"
"screwdriver-data-schema": "file:../data-schema/screwdriver-data-schema-22.0.0.tgz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be updated to the new data-schema version.

@sagar1312 sagar1312 changed the title feat(3171): Pull in latest data-schema to persist pipeline template workflowGraph in a new column (BREAKING CHANGE) feat(3171): Pull in latest data-schema to persist pipeline template workflowGraph in a new column Aug 30, 2024
@sagar1312 sagar1312 force-pushed the sagar1312-fix-3171-pipeline_template_workflowgraph branch from 12183c1 to 9916a17 Compare August 30, 2024 20:06
@sagar1312 sagar1312 marked this pull request as ready for review August 30, 2024 20:08
@sagar1312 sagar1312 merged commit c639e53 into master Aug 30, 2024
2 checks passed
@sagar1312 sagar1312 deleted the sagar1312-fix-3171-pipeline_template_workflowgraph branch August 30, 2024 21:06
@sd-buildbot
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants