Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVPLAT-3092] Upgrade go to v1.24 #140

Merged
merged 26 commits into from
Feb 17, 2025
Merged

Conversation

Neurostep
Copy link
Contributor

@Neurostep Neurostep commented Feb 17, 2025

Description

In this PR we upgrade the Go version to v1.24.0.

Alongside the Go version upgrade, we upgrade the direct dependencies as well. The notable updates are:

  • cors package, now it is mandatory to specify the OPTIONS HTTP response code
  • viper has changed the behavior of the AllKeys function and now expected keys need to be specified in the YAML config as well
  • grpc deprecated the usage of grpc.Dial function in favor of grpc.NewClient

Other dependencies do not require the codebase change.

Testing considerations

  • Upgrade go-sdk in go-chassis and test end-to-end + DataDog dashboards

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@Neurostep Neurostep marked this pull request as ready for review February 17, 2025 12:20
@Neurostep Neurostep requested a review from a team as a code owner February 17, 2025 12:20
@Neurostep Neurostep requested a review from basmscribd February 17, 2025 12:20
Copy link
Member

@terranisu terranisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Neurostep Neurostep merged commit ba4516d into main Feb 17, 2025
10 checks passed
@Neurostep Neurostep deleted the maksimt/DEVPLAT-3092/upgrade-go branch February 17, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants