Skip to content

Commit

Permalink
feat: remove terraform resource for ELB bucket ACL configuration (ter…
Browse files Browse the repository at this point in the history
…raform-only change)

Stops managing aws_s3_bucket_acl given AWS's new standard for ACLs:
https://aws.amazon.com/about-aws/whats-new/2022/12/amazon-s3-automatically-enable-block-public-access-disable-access-control-lists-buckets-april-2023/

When updating, the`module.datadog.aws_s3_bucket_acl.elb_logs[0]` will be destroyed, but this will not impact the actual ACL of the bucket. 

Thanks, @frozenSolid!
  • Loading branch information
frozenSolid authored Jul 17, 2023
1 parent 42b9a57 commit fc770ec
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions logs_monitoring_elb.tf
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,6 @@ resource "aws_s3_bucket_policy" "elb_logs" {
policy = data.aws_iam_policy_document.elb_logs.json
}

resource "aws_s3_bucket_acl" "elb_logs" {
count = var.create_elb_logs_bucket ? 1 : 0
bucket = aws_s3_bucket.elb_logs[0].id
acl = "private"
}

resource "aws_s3_bucket_lifecycle_configuration" "elb_logs" {
count = var.create_elb_logs_bucket ? 1 : 0
bucket = aws_s3_bucket.elb_logs[0].id
Expand Down

0 comments on commit fc770ec

Please sign in to comment.