remove scribd specific content #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim80net
reviewed
Feb 22, 2020
houqp
force-pushed
the
ossprep
branch
2 times, most recently
from
bffa129
to
c9f49f0
Compare
|
I am going to add CI/CD in a separate PR to make things easier to review |
jim80net
suggested changes
Feb 22, 2020
added 2 commits
February 21, 2020 17:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all scribd specific content from the code base. @jim80net let me know if you think I missed anything.
Had to introduce one breaking change for the ELB bucket name unfortunately :( We can manually go in and update our stacks to use scribd as prefix.
Before we make this repo public, we need to squash all the commits into one.