Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable support for Terraform 1.1.3 #40

Merged
merged 1 commit into from
Jan 14, 2022
Merged

feat: enable support for Terraform 1.1.3 #40

merged 1 commit into from
Jan 14, 2022

Conversation

nbaec
Copy link
Contributor

@nbaec nbaec commented Jan 14, 2022

Updating this module to work with Terraform versions up to, but not including, 1.3.0.

@nbaec
Copy link
Contributor Author

nbaec commented Jan 14, 2022

Hey @jim80net and @houqp, not able to request reviews but would love a review on this 🚀 Thanks in advance!

@houqp houqp merged commit 51c5279 into scribd:master Jan 14, 2022
@houqp
Copy link
Contributor

houqp commented Jan 14, 2022

thanks @nbaec , I am wondering whether we should just pin it to 1.x and hope hashicorp doesn't introduce breaking changes within major release.

github-actions bot pushed a commit that referenced this pull request Jan 19, 2022
# [2.6.0](v2.5.0...v2.6.0) (2022-01-19)

### Bug Fixes

* explicitly specify the versions for semantic-release ([#42](#42)) ([09bd8b9](09bd8b9))

### Features

* enable support for Terraform 1.1.3 ([#40](#40)) ([51c5279](51c5279))
@github-actions
Copy link

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to YouLend/terraform-aws-datadog that referenced this pull request Nov 8, 2023
# [3.0.0](v2.5.0...v3.0.0) (2023-11-08)

### Bug Fixes

* 6764: add eks iam permissions to datadog policy ([215210f](215210f))
* 6764: add the dev datadog role in the sts assume role ([518ccfe](518ccfe))
* 6764: remove aws tag filter for rds ([1981c9e](1981c9e))
* 6764: remove depcreted arguments from s3 ([ece8ee0](ece8ee0))
* 6764: remove dev account from sts ([1b8962d](1b8962d))
* 6764: remove lifecyle rule ([c4415fd](c4415fd))
* 6764: remove rds tag filter ([3edff7e](3edff7e))
* 6764: remove required version in module ([a70a53b](a70a53b))
* 6764: remove sts for usprod and dev ([e4e4280](e4e4280))
* 6764: solve merge conflict ([30b4a41](30b4a41))
* 6764: solve merge conflict2 ([917b3ae](917b3ae))
* 6764: test rds namespace tag filter ([3c96389](3c96389))
* 6764: update the name of elb log bucket ([a1b57aa](a1b57aa))
* 7413: update release tags ([c6d43fa](c6d43fa))
* 7413: update release tags ([17bb1ce](17bb1ce))
* explicitly specify the versions for semantic-release ([scribd#42](https://github.com/YouLend/terraform-aws-datadog/issues/42)) ([09bd8b9](09bd8b9))
* hosted_tags: making host_tags and filter_tags ([9dbf24f](9dbf24f))
* restrict aws provider to <4 for this major branch ([scribd#47](https://github.com/YouLend/terraform-aws-datadog/issues/47)) ([07de45a](07de45a))

* feat!: enable support for aws provider 4.0+ (scribd#49) ([5bc98cb](5bc98cb)), closes [scribd#49](https://github.com/YouLend/terraform-aws-datadog/issues/49)

### Features

* (HEAD: adding waf logging in Datadog ([7c96569](7c96569))
* 6764: add cspm_resource_collection_enabled ([e6ce70f](e6ce70f))
* 6764: add cspm_resource_collection_enabled ([02c26a2](02c26a2))
* 6764: add dev and usprod in the sts assume role ([5bdfb8d](5bdfb8d))
* 6764: add lambda forward function ([543caf4](543caf4))
* 6764: add metrics collection and update iam role ([440d86e](440d86e))
* 6764: add rds tag filters ([dbbddc3](dbbddc3))
* 6764: pre-commit ([3b0babe](3b0babe))
* 6764: remove db uat from datadog ([8731628](8731628))
* 6764: remove uat db from monitoring ([e57525e](e57525e))
* 6764: testing aws tag filter ([de928e1](de928e1))
* 6764: testing aws tag filter ([f6fbb9f](f6fbb9f))
* 7413: terraform required version change to 1.1.0 ([1a2379f](1a2379f))
* 7413: upgrade Module DataDog v2.5.0 ([28cd263](28cd263))
* enable support for Datadog provider 3.x ([e42de0e](e42de0e))
* enable support for Terraform 1.1.3 ([scribd#40](https://github.com/YouLend/terraform-aws-datadog/issues/40)) ([51c5279](51c5279))

### BREAKING CHANGES

* This release drops support for AWS provider <4.0

When updating to this version, the diff will show each of the new resources as needing to be created. However, each of the new aws_s3_bucket_* resources relies on S3 API calls that utilize a PUT action in order to modify the target S3 bucket. Because these API calls adhere to standard HTTP methods for REST APIs, they should handle situations where the target configuration already exists (as noted in the HTTP RFC). Given that this is the case, it's not strictly necessary to import any new aws_s3_bucket_* resources that are a one-to-one translation from previous versions of the AWS provider -- on the next terraform apply, they'll attempt the PUT, and update the state with the results as necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants