Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize conjugation properties for Spanish and Portuguese verbs #7

Closed
2 tasks done
andrewtavis opened this issue Nov 23, 2021 · 4 comments
Closed
2 tasks done
Assignees
Labels
data Relates to data or Wikidata good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Nov 23, 2021

Terms

Languages

Spanish and Portuguese

Description

A slight annoyance with getting verb conjugations for Wikidata at the moment is that they're not categorized in a consistent manner. As can be seen in data/Spanish/verbs/query_verbs.sparql, verb conjugations need to be done in two ways as some conjugations are categorized using combined properties. An example is that first person singular indicative present conjugations can be queried using two different combinations of properties:

wikibase:grammaticalFeature wd:Q21714344 ; # first person
wikibase:grammaticalFeature wd:Q110786 ; # singular
wikibase:grammaticalFeature wd:Q682111 ; # indicative
wikibase:grammaticalFeature wd:Q192613 ; # present tense

and

wikibase:grammaticalFeature wd:Q51929218 ; # first-person singular
wikibase:grammaticalFeature wd:Q56682909 ; # present indicative

This firstly makes the query longer, and will doubtless lead to issues down the road. Keeping all properties separated to their fullest extent makes sense so that they can be consistently used - i.e. queries could always use present tense Q192613 and not use a version that includes indicative or another case. These can be added to the base queries.

There still are not that many Spanish verbs on Wikidata at the moment, so now is an ideal time to standardize this information.

@andrewtavis andrewtavis added good first issue Good for newcomers help wanted Extra attention is needed data Relates to data or Wikidata labels Nov 23, 2021
@andrewtavis andrewtavis changed the title Standardizing the conjugation properties for Spanish verbs Standardize conjugation properties for Spanish verbs Nov 30, 2021
@andrewtavis
Copy link
Member Author

Note also that this problem is also present for Portuguese. See: abalar and ser for instances of the different categorizing methods.

@andrewtavis
Copy link
Member Author

Also note that many Portuguese verbs are using Q64005357, which is undefined, rather than Q23663136 for past perfect.

@andrewtavis andrewtavis changed the title Standardize conjugation properties for Spanish verbs Standardize conjugation properties for Spanish and Portuguese verbs Jan 5, 2022
@andrewtavis andrewtavis transferred this issue from scribe-org/Scribe-iOS Mar 29, 2022
@andrewtavis
Copy link
Member Author

Note that it's been long enough that a check of if those other conditionals could be removed makes sense :) We'd just remove them and see if roughly the same number of verbs comes out :)

@andrewtavis
Copy link
Member Author

Closed in 9a13dd3 :) Spanish is now fully up to date with not using the combined properties, and there are so few Italian verbs that to me it's fine that this is closed as the new standards dictate that such combined properties should not be used going forward.

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Apr 13, 2023
andrewtavis added a commit that referenced this issue Apr 13, 2023
@andrewtavis andrewtavis self-assigned this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Relates to data or Wikidata good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

1 participant