Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically size Scribe command UI #29

Closed
andrewtavis opened this issue Nov 23, 2021 · 2 comments
Closed

Dynamically size Scribe command UI #29

andrewtavis opened this issue Nov 23, 2021 · 2 comments
Assignees
Labels
-priority- High priority design Relates to UX/UI designs good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Nov 23, 2021

This issue is a major priority for Scribe's UI. What's needed is edits to KeyboardViewController.swift and Keyboard.xib files to make Scribe keyboard elements dynamically sized. As of now the height of the Scribe key, command bar, and other command keys is set by Keyboard.xib, whereas it should instead be sized within KeyboardViewController.swift so that the height can account for the keyboard height.

Of importance is that the aforementioned elements are currently taller than they need to be, which then reduces the available space for the keys. Keys on Scribe keyboards are currently slightly smaller than system keyboards and closer together regarding the y-axis, so it would be better to reduce the height of Scribe command elements so that it can be used to properly layout the keys.

This issue can also include a check of keyboardHeight in KeyboardViewController.swift, which could also be dynamically sized.

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed design Relates to UX/UI designs -priority- High priority labels Nov 23, 2021
@andrewtavis
Copy link
Member Author

andrewtavis commented Jan 20, 2022

A potential solution to this is linking the height of the command elements - the Scribe button, command bar, and other command buttons - to the stack views on which the keyboard buttons are laid out within Keyboard.xib.

@andrewtavis andrewtavis added good first issue Good for newcomers and removed feature New feature or request labels Jan 20, 2022
@andrewtavis
Copy link
Member Author

The above comment was implemented in d6c4ed9 for the design sprint in #112 to close this issue. The elements of the Scribe command interface are sized dynamically to a background element that's sized relative to the stack views.

@andrewtavis andrewtavis mentioned this issue Jan 25, 2022
26 tasks
@andrewtavis andrewtavis self-assigned this Apr 7, 2023
wkyoshida added a commit to wkyoshida/Scribe-iOS that referenced this issue Aug 2, 2024
812482a Merge pull request scribe-org#30 from weblate/weblate-scribe-scribe-i18n
446ec73 Translated using Weblate (Spanish)
c553b4e Merge pull request scribe-org#29 from weblate/weblate-scribe-scribe-i18n
80c0a4e Translated using Weblate (Swedish)
563a96f Translated using Weblate (Spanish)
416a9e4 Translated using Weblate (German)
019a084 Translated using Weblate (English (United States))
41f7450 Translated using Weblate (English (United States))
74263da Translated using Weblate (English (United States))
ba64ae1 Translated using Weblate (English (United States))
0e2f944 Minor updates to readme headers and text
d9b2226 Merge pull request scribe-org#26 from Jag-Marcel/action-fix
0cb65ed Small fix to action for converting jsons to xcstrings
cd28e5e Merge pull request scribe-org#25 from weblate/weblate-scribe-scribe-i18n
dc922d8 Translated using Weblate (Swedish)
997460b Translated using Weblate (Spanish)
a99deb4 Translated using Weblate (German)
eff6dee Merge pull request scribe-org#24 from Jag-Marcel/new-strings
7ad62b4 Merge branch 'main' into new-strings
b020823 Merge pull request scribe-org#23 from weblate/weblate-scribe-scribe-i18n
463dd85 New strings for Scribe-iOS translation picker
dde9e54 Translated using Weblate (Swedish)
65d4274 Translated using Weblate (Swedish)
f2c989d Translated using Weblate (Swedish)
d230853 Merge pull request scribe-org#22 from Jag-Marcel/minor-fix
dc219d4 Minor fix to conversion script

git-subtree-dir: Scribe/i18n
git-subtree-split: 812482a104212e84ccb7aa620e580e9130a6581b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority design Relates to UX/UI designs good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant