Skip to content
This repository has been archived by the owner on May 2, 2020. It is now read-only.

Option to change body background color with phone frame / limited application size #679

Closed
gcshri opened this issue Oct 24, 2017 · 3 comments
Closed

Option to change body background color with phone frame / limited application size #679

gcshri opened this issue Oct 24, 2017 · 3 comments
Labels
new feature

Comments

@gcshri
Copy link

gcshri commented Oct 24, 2017

I am trying to create a fixed width desktop app with the framework and have set the following options:

  "iconBackgroundColor": "#eeeeee",

  "limitApplicationWidth": 1200,
  "limitApplicationHeight": "100%",
  "showPhoneFrameOnDesktop": false,

index.ejs in the node_modules/... folder has this but the color does not seem to change.

  <body style="background: <%= htmlWebpackPlugin.options.iconBackgroundColor %>">

The body is styled as follows when I run the dev server.

<body style="background: rgb(51, 51, 51);" class="limitWidth theme-indigo">

Also noticed that 'limitWidth/limtHeight' has the style

.limitHeight, .limitWidth {
    background: #333333;
}

Am I missing something?
@scriptPilot
Copy link
Owner

@gcshri - Please can you specify your question and the steps you did / the expected result / the actual result - thanks.

@gcshri
Copy link
Author

gcshri commented Oct 27, 2017

Sorry, should have added a screenshot.

When I configure the app to have a fixed width on the desktop using "limitApplicationWidth" in the config.json, how would I change the background color. Currently fixed in the body tag as mentioned above.

screen shot 2017-10-27 at 4 19 29 pm

@scriptPilot scriptPilot changed the title <body> Background on Desktop showPhoneFrameOnDesktop = False Option to change body background color with limited application size Oct 27, 2017
@scriptPilot
Copy link
Owner

OK, now I've got that point - I will add a configuration option to make it clean.

@scriptPilot scriptPilot changed the title Option to change body background color with limited application size Option to change body background color with phone frame / limited application size Oct 27, 2017
scriptPilot pushed a commit that referenced this issue Oct 27, 2017
Merge pull request #686 from scriptPilot/feature-679
552c654 
closes #679
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gcshri @scriptPilot