Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for triggers and associated functions #68

Merged
merged 15 commits into from
May 10, 2022
Merged

Add support for triggers and associated functions #68

merged 15 commits into from
May 10, 2022

Conversation

jsynacek
Copy link
Contributor

@jsynacek jsynacek commented Apr 1, 2022

No description provided.

@jsynacek jsynacek marked this pull request as draft April 1, 2022 11:00
@jsynacek jsynacek force-pushed the jsynacek-triggers branch 4 times, most recently from f3fe2c0 to b02fb04 Compare April 7, 2022 12:14
@jsynacek jsynacek force-pushed the jsynacek-triggers branch 2 times, most recently from 5caf926 to 3a44e59 Compare April 12, 2022 08:23
@jsynacek jsynacek changed the title WIP: Initial support for defining triggers Add support for triggers and associated functions Apr 12, 2022
@jsynacek jsynacek requested a review from arybczak April 12, 2022 08:24
@jsynacek jsynacek marked this pull request as ready for review April 12, 2022 08:25
arybczak
arybczak reviewed Apr 12, 2022
View reviewed changes
src/Database/PostgreSQL/PQTypes/Checks.hs Outdated Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Checks.hs Outdated Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Model/Trigger.hs Outdated Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Model/Trigger.hs Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Model/Trigger.hs Outdated Show resolved Hide resolved
test/Main.hs Outdated Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Model/Trigger.hs Outdated Show resolved Hide resolved
test/Main.hs Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Model/Trigger.hs Outdated Show resolved Hide resolved
@jsynacek jsynacek requested a review from arybczak April 13, 2022 10:18
arybczak
arybczak reviewed Apr 29, 2022
View reviewed changes
test/Main.hs Outdated Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Checks.hs Outdated Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Model/Trigger.hs Outdated Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Model/Trigger.hs Outdated Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Model/Trigger.hs Outdated Show resolved Hide resolved
@jsynacek jsynacek requested a review from arybczak May 3, 2022 10:30
jsynacek added 7 commits May 4, 2022 15:21
@jsynacek
Add support for triggers and associated functions
74b1b3f
@jsynacek
Make getDBTriggers accept table name as an argument and filter trigge…
e4a2fa7 
…rs in db
@jsynacek
Remove testing code
dcfb431
@jsynacek
Improve test suite
855cacd
@jsynacek
Address review comments
c84100e 
* Remove superfluous semicolon
* Remove Eq instance for Trigger
* Compare WHEN clauses in a similar manner as CHECKs are compared
* Use do blocks instead of variable shadowing
@jsynacek
Use unsafeSQL instead of fromString
98a3dc2
@jsynacek
Address more concerns
c7faa21 
* Use unsafeSQL instead of fromString
* Update TODO with issue link
* Add dropTrigger
* CreateTriggerMigration Trigger should not exit. It should be just a function that can be
  added to any StandardMigration
* Rewrite tests using createTrigger and StandardMigration and add more tests for
  dropTrigger as well
@jsynacek jsynacek force-pushed the jsynacek-triggers branch from 1bf9462 to c7faa21 Compare May 4, 2022 16:01
jsynacek
jsynacek commented May 4, 2022
View reviewed changes
test/Main.hs Outdated Show resolved Hide resolved
@jsynacek jsynacek requested a review from marco44 May 9, 2022 11:34
marco44
marco44 approved these changes May 9, 2022
View reviewed changes
Copy link

@marco44 marco44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved to the best of my capabilities, which is not a lot in haskell :)

arybczak
arybczak approved these changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@arybczak arybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I added 3 minor comments.

src/Database/PostgreSQL/PQTypes/Model/Trigger.hs Outdated Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Model/Trigger.hs Outdated Show resolved Hide resolved
src/Database/PostgreSQL/PQTypes/Model/Trigger.hs Outdated Show resolved Hide resolved
jsynacek and others added 3 commits May 10, 2022 09:14
@jsynacek @arybczak
Update src/Database/PostgreSQL/PQTypes/Model/Trigger.hs
0322346 
Co-authored-by: Andrzej Rybczak <arybczak@users.noreply.github.com>
@jsynacek @arybczak
Update src/Database/PostgreSQL/PQTypes/Model/Trigger.hs
5c2df39 
Co-authored-by: Andrzej Rybczak <arybczak@users.noreply.github.com>
@jsynacek
Use foldl' instead of foldl
5783ebf
@jsynacek jsynacek merged commit a3f59aa into master May 10, 2022
@jsynacek jsynacek deleted the jsynacek-triggers branch May 10, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arybczak arybczak arybczak approved these changes

@marco44 marco44 marco44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsynacek @marco44 @arybczak