Store pid of the backend when connecting to Postgres #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arybczak
force-pushed
the
backend-pid
branch
2 times, most recently
from
a7a136d to
ffceebf
Compare
Raveline
approved these changes
Mar 1, 2024
| getBackendPidIO :: Connection -> IO Int | ||
| getBackendPidIO conn = do | ||
| withConnectionData conn "getBackendPidIO" $ \cd -> do | ||
| pure (cd, cdBackendPid cd) |
There was a problem hiding this comment.
I would dispense with the do here, to be honest, but I guess from our hlint.yaml there is no in-house policy against redundant do ?
There was a problem hiding this comment.
While do is technically redundant, it's there to appease haskell-mode formatter in emacs to do the right thing 👻
| @@ -370,8 +396,7 @@ runQueryImpl fname conn sql execSql = do | |||
| , statsValues = statsValues cdStats + (rows * columns) | |||
| , statsParams = statsParams cdStats + paramCount | |||
| } | |||
| -- Force evaluation of modified stats to squash a space leak. | |||
| stats' `seq` return (cd {cdStats = stats'}, (either id id affected, res)) | |||
| return (cd {cdStats = stats'}, (either id id affected, res)) | |||
There was a problem hiding this comment.
What about using pure rather than return since it's what you used everywhere else ?
There was a problem hiding this comment.
Right, although there's tons of return in other places, so whether I replace this one or not is irrelevant. Let's leave it for later when hlint is enabled for this repo, it can be then done systematically for all occurrences.
|
I added newtype for the pid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.