Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support —moduleResolution node16 #882

Merged
merged 4 commits into from
Apr 8, 2023

Conversation

long76
Copy link
Contributor

@long76 long76 commented Apr 6, 2023

i tested it locally

@long76
Copy link
Contributor Author

long76 commented Apr 6, 2023

@long76
Copy link
Contributor Author

long76 commented Apr 6, 2023

@stipsan pr for #1176, need two merge, sorry)

@long76 long76 mentioned this pull request Apr 7, 2023
@long76
Copy link
Contributor Author

long76 commented Apr 7, 2023

@stipsan please approve workflow

@long76
Copy link
Contributor Author

long76 commented Apr 8, 2023

@stipsan compute works (i chek it with npm link) not see problem for merge

@stipsan stipsan changed the title fix TS1479 fix: support —moduleResolution node16 Apr 8, 2023
@stipsan stipsan merged commit d4ad5e1 into scroll-into-view:main Apr 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@long76 long76 deleted the patch-1 branch April 9, 2023 05:29
long76 added a commit to long76/compute-scroll-into-view that referenced this pull request Apr 9, 2023
stipsan pushed a commit that referenced this pull request Apr 9, 2023
* revert package.json #882

* revert utils.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants