fix: avoid committing empty blocks after the deadline (#1051)

scroll-tech · Sep 20, 2024 · c0094ee · c0094ee
1 parent d599666
commit c0094ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/miner/scroll_worker.go b/miner/scroll_worker.go
@@ -396,7 +396,7 @@ func (w *worker) mainLoop() {
  // be automatically eliminated.
  if w.current != nil {
  shouldCommit, _ := w.processTxnSlice(ev.Txs)
- if shouldCommit || w.current.deadlineReached {
+ if shouldCommit || (w.current.deadlineReached && len(w.current.txs) > 0) {
  _, err = w.commit()
  }
  }

diff --git a/params/version.go b/params/version.go
@@ -24,7 +24,7 @@ import (
 const (
  VersionMajor = 5 // Major version component of the current release
  VersionMinor = 7 // Minor version component of the current release
- VersionPatch = 19 // Patch version component of the current release
+ VersionPatch = 20 // Patch version component of the current release
  VersionMeta = "mainnet" // Version metadata to append to the version string
 )