(Don't merge) add log to debug tx latency

[georgehao]

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
• ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
• docs: Documentation-only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
• test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

• This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change
• Yes

Summary by CodeRabbit

• New Features
  • Transaction processing now includes enhanced logging that displays key details such as transaction identifier, recipient, and sender information for improved transparency and monitoring.

[coderabbitai]

Walkthrough

The pull request updates the TxPool's addTxs method by capturing and logging the sender’s address when a transaction is added. Previously, the sender was discarded after being derived via types.Sender(pool.signer, tx), but now it is stored in the variable from and included in the log alongside the transaction hash and recipient. The error handling and overall logic for validation and pooling remain unchanged.

Changes

File(s)	Change Summary
core/tx_pool.go	Modified addTxs method to capture the sender's address in a variable (from) and log it with the transaction hash and recipient. Error handling is unchanged.

Possibly related PRs

• feat(txpool): add logs to track txns #1046: Related to enhancements in transaction logging within the TxPool implementation.

Suggested reviewers

• Thegaram
• colinlyguo
• omerfirmak

Poem

I'm a rabbit with a coding hop,
Logging senders non-stop.
A simple tweak, a thoughtful log,
Keeping transactions clear through the fog.
Happy hops in our code garden, let's never stop!
🐰💻

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 048db62 and fd79dfa.

📒 Files selected for processing (1)

• core/tx_pool.go (1 hunks)

🧰 Additional context used

🧬 Code Definitions (1)

core/tx_pool.go (1)

core/types/transaction_signing.go (1)

• Sender (141-158)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: build-and-push
• GitHub Check: test
• GitHub Check: Analyze (go)

🔇 Additional comments (1)

core/tx_pool.go (1)

1123-1129: Enhanced logging for transaction pool debugging.

This change captures the sender's address and adds it to the log message when a transaction is added to the pool. This is a good addition for debugging transaction latency issues, as mentioned in the PR objectives.

Note that this logs at the Info level, which will generate logs for every transaction added to the pool. This is appropriate for temporary debugging but might be too verbose for production usage. Consider moving to Debug level if this logging will be retained long-term.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.