-
Notifications
You must be signed in to change notification settings - Fork 283
fix(txpool): tracing txn executed status #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(txpool): tracing txn executed status #1168
Conversation
WalkthroughThis update modifies the logging behavior in the transaction pool. In the event loop, a new debug log records the hash of each transaction when added to the blockchain. In the reset method, previous separate log messages for discarded and included transactions during a reorganization have been consolidated into a single log statement indicating the removal of transactions due to a chain reorganization. Additionally, the patch version in the versioning system has been incremented from 37 to 38. Changes
Sequence Diagram(s)sequenceDiagram
participant TxPool
participant Logger
Note over TxPool: Processing new block
TxPool->>Logger: Log each transaction hash from block
Note over TxPool: Handling reorg event in reset method
TxPool->>Logger: Log consolidated reorg removal message
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
1. Purpose or design rationale of this PR
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?Summary by CodeRabbit