Skip to content

Conversation

yiweichi
Copy link
Member

@yiweichi yiweichi commented Jul 29, 2025

1. Purpose or design rationale of this PR

This PR improve blob client beacon node, supports do http call with ctx timeout.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling for retrieving blobs, ensuring more reliable and informative responses when network issues occur.
  • Chores
    • Updated the application version to patch 0.75.

Copy link

coderabbitai bot commented Jul 29, 2025

Walkthrough

The GetBlobByVersionedHashAndBlockTime method in BeaconNodeClient was updated to construct HTTP requests explicitly using http.NewRequestWithContext and execute them with c.client.Do, replacing the previous direct use of c.client.Get. Error handling was refined to address request creation and execution separately. Additionally, the patch version constant VersionPatch was incremented from 74 to 75 in params/version.go.

Changes

Cohort / File(s) Change Summary
HTTP Request Refactor
rollup/da_syncer/blob_client/beacon_node_client.go
Refactored HTTP GET logic in GetBlobByVersionedHashAndBlockTime to use explicit request creation and execution; improved error handling for request creation and execution steps.
Version Bump
params/version.go
Incremented patch version constant VersionPatch from 74 to 75 without other code or logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5-10 minutes

Possibly related PRs

Suggested reviewers

  • Thegaram
  • colinlyguo

Poem

In the code where blobs and hashes meet,
A rabbit hopped with nimble feet.
Requests now crafted, context in tow,
Errors caught before they grow.
With careful paws and whiskers keen,
The syncer’s path is clear and clean! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb267b8 and 7af56ba.

📒 Files selected for processing (1)
  • params/version.go (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • params/version.go
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-blob-client-beacon-node-request-with-context

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yiweichi yiweichi changed the title fix: blob client beacon node request with context fix: blob client beacon node do http request with context Jul 29, 2025
colinlyguo
colinlyguo previously approved these changes Jul 29, 2025
@yiweichi yiweichi changed the base branch from develop to fix-requests-hash-in-sdk July 29, 2025 11:08
@yiweichi yiweichi closed this Jul 29, 2025
@yiweichi yiweichi reopened this Jul 29, 2025
@yiweichi yiweichi changed the base branch from fix-requests-hash-in-sdk to develop July 29, 2025 11:15
@yiweichi yiweichi dismissed colinlyguo’s stale review July 29, 2025 11:15

The base branch was changed.

@yiweichi yiweichi requested a review from colinlyguo July 29, 2025 11:15
@yiweichi yiweichi merged commit 4c967ae into develop Jul 29, 2025
4 checks passed
@yiweichi yiweichi deleted the fix-blob-client-beacon-node-request-with-context branch July 29, 2025 11:30
jonastheis pushed a commit that referenced this pull request Jul 31, 2025
* fix: beacon node client request with context

* chore: auto version bump [bot]
jonastheis added a commit that referenced this pull request Jul 31, 2025
…enabled (#1227)

* make sequencer forwarding non-blocking if tx pool is enabled

* chore: auto version bump [bot]

* address review comments

* chore: auto version bump [bot]

* fix: blob client beacon node do http request with context (#1228)

* fix: beacon node client request with context

* chore: auto version bump [bot]

---------

Co-authored-by: Morty <70688412+yiweichi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants