Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trace): more consistent invalid opcode trace #487

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

lispc
Copy link

@lispc lispc commented Aug 27, 2023

1. Purpose or design rationale of this PR

in current trace for invalid opcode, eg for 0xB0, the struct log will be "error": "invalid opcode: DUP",. After this PR, it will become "error": "invalid opcode: 0xb0",, which is consistent with other invalid opcodes. This is also the behavior of upstream HEAD

related upstream PR: ethereum#23956

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@lispc lispc changed the title fix: more consistent invalid opcode trace (wip) fix: more consistent invalid opcode trace Aug 27, 2023
@lispc lispc marked this pull request as draft August 27, 2023 05:22
@lispc lispc force-pushed the fix/better-invalid-opcode-trace branch from 9be0821 to 8e452d4 Compare August 27, 2023 23:31
@lispc lispc changed the title (wip) fix: more consistent invalid opcode trace fix: more consistent invalid opcode trace Aug 27, 2023
@lispc lispc marked this pull request as ready for review August 27, 2023 23:32
@lispc lispc requested a review from Thegaram August 27, 2023 23:35
HAOYUatHZ
HAOYUatHZ previously approved these changes Aug 29, 2023
Thegaram
Thegaram previously approved these changes Aug 30, 2023
core/vm/opcodes.go Show resolved Hide resolved
@lispc lispc changed the title fix: more consistent invalid opcode trace fix(trace): more consistent invalid opcode trace Aug 31, 2023
@Thegaram Thegaram merged commit d45613f into develop Aug 31, 2023
5 checks passed
@Thegaram Thegaram deleted the fix/better-invalid-opcode-trace branch August 31, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants