Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trace): record account proof for ErrContractAddressCollision #488

Merged
merged 7 commits into from
Sep 4, 2023

Conversation

lispc
Copy link

@lispc lispc commented Aug 27, 2023

1. Purpose or design rationale of this PR

we need the 'to' account nonce and codehash to prove ErrContractAddressCollision. Without this fix, it is missing in storage proof in trace.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@lispc lispc requested a review from noel2004 August 27, 2023 23:35
noel2004
noel2004 previously approved these changes Aug 28, 2023
Copy link
Member

@noel2004 noel2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for some trivial notes

core/vm/logger.go Show resolved Hide resolved
@lispc lispc changed the title fix(trace): record account proof for ErrContractAddressCollision (don't merge) fix(trace): record account proof for ErrContractAddressCollision Sep 1, 2023
@lispc lispc changed the title (don't merge) fix(trace): record account proof for ErrContractAddressCollision fix(trace): record account proof for ErrContractAddressCollision Sep 1, 2023
@scroll-dev scroll-dev merged commit 2d9d48d into develop Sep 4, 2023
5 checks passed
@scroll-dev scroll-dev deleted the fix/record_create2_to_account_proof branch September 4, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants