Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modexp): disallow len of 0x8000000000000000000000000000000000000000000… #496

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

lispc
Copy link

@lispc lispc commented Aug 31, 2023

…000000000000000000000

1. Purpose or design rationale of this PR

An edge case is, when baseLen == 0 and modLen == 0, expLen can be value like 0x8000000000000000000000000000000000000000000000000000000000000000 , it is still valid and can be run successfully.

This PR will reject this input.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop merged commit ef328db into develop Aug 31, 2023
5 checks passed
@0xmountaintop 0xmountaintop deleted the fix/modexp-len branch August 31, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants