Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ccc): throw error instead of panic for recognized errors #499

Merged
merged 13 commits into from
Sep 6, 2023
Merged

refactor(ccc): throw error instead of panic for recognized errors #499

merged 13 commits into from
Sep 6, 2023

Conversation

Lawliet-Chan
Copy link

@Lawliet-Chan Lawliet-Chan commented Sep 4, 2023 •
edited
Loading

1. Purpose or design rationale of this PR

Reduce the panics of circuit-capacity-checker, instead of Err

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@Lawliet-Chan Lawliet-Chan marked this pull request as draft September 4, 2023 07:25
@Lawliet-Chan Lawliet-Chan marked this pull request as ready for review September 5, 2023 02:04
@0xmountaintop 0xmountaintop changed the title reduce ccc panic refactor(ccc): throw error instead of panic for recognized errors Sep 5, 2023
0xmountaintop
0xmountaintop previously approved these changes Sep 5, 2023
View reviewed changes
0xmountaintop
0xmountaintop previously approved these changes Sep 5, 2023
View reviewed changes
silathdiir
silathdiir previously approved these changes Sep 5, 2023
View reviewed changes
Copy link

@silathdiir silathdiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rollup/circuitcapacitychecker/libzkp/src/lib.rs Show resolved Hide resolved
rollup/circuitcapacitychecker/libzkp/src/lib.rs Show resolved Hide resolved
@Lawliet-Chan @georgehao
Apply suggestions from code review
2b74666 
Co-authored-by: georgehao <haohongfan@gmail.com>
@0xmountaintop 0xmountaintop merged commit 293deff into develop Sep 6, 2023
5 checks passed
@0xmountaintop 0xmountaintop deleted the recover_ccc branch September 6, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmountaintop 0xmountaintop 0xmountaintop approved these changes

@georgehao georgehao georgehao approved these changes

@silathdiir silathdiir silathdiir left review comments

@Thegaram Thegaram Awaiting requested review from Thegaram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lawliet-Chan @georgehao @Thegaram @silathdiir @0xmountaintop