Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use light_mode = false for block ccc #519

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

lispc
Copy link

@lispc lispc commented Sep 18, 2023

1. Purpose or design rationale of this PR

use "non light" mode for follower ccc, to get accurate row usage estimation. By using this, we estimate gas/chunk can be doubled on average.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@lispc lispc marked this pull request as draft September 18, 2023 09:23
@lispc lispc marked this pull request as ready for review September 26, 2023 06:37
@HAOYUatHZ HAOYUatHZ merged commit a51434d into develop Sep 27, 2023
5 checks passed
@HAOYUatHZ HAOYUatHZ deleted the testing/opt-chunk-ccc branch September 27, 2023 06:30
Thegaram added a commit that referenced this pull request Sep 27, 2023
@Thegaram Thegaram mentioned this pull request Sep 27, 2023
5 tasks
Thegaram added a commit that referenced this pull request Sep 27, 2023
* Revert "feat: use light_mode = false for block ccc (#519)"

This reverts commit a51434d.

* bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants