Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ethclient): export GetTxBlockTraceOnTopOfBlock & GetNumSkippedTransactions & GetSkippedTransactionHashes & GetSkippedTransaction #644

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

HAOYUatHZ
Copy link
Member

@HAOYUatHZ HAOYUatHZ commented Feb 23, 2024

1. Purpose or design rationale of this PR

add the following methods for ethclient:

  • GetTxBlockTraceOnTopOfBlock
  • GetNumSkippedTransactions
  • GetSkippedTransactionHashes
  • GetSkippedTransaction

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@HAOYUatHZ HAOYUatHZ changed the title feat(api): export GetTxBlockTraceOnTopOfBlock featethclient): export GetTxBlockTraceOnTopOfBlock Feb 23, 2024
@HAOYUatHZ HAOYUatHZ changed the title featethclient): export GetTxBlockTraceOnTopOfBlock feat(ethclient): export GetTxBlockTraceOnTopOfBlock Feb 23, 2024
@HAOYUatHZ HAOYUatHZ changed the title feat(ethclient): export GetTxBlockTraceOnTopOfBlock feat(ethclient): export GetTxBlockTraceOnTopOfBlock & GetNumSkippedTransactions & GetSkippedTransactionHashes & GetSkippedTransaction Feb 23, 2024
@HAOYUatHZ
Copy link
Member Author

@HAOYUatHZ HAOYUatHZ merged commit dab4354 into develop Mar 11, 2024
6 checks passed
@HAOYUatHZ HAOYUatHZ deleted the more_api branch March 11, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants