Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup-verifier): hardcode genesis codec version as codecv0 and sync codecv1 implementation #699

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Apr 12, 2024

1. Purpose or design rationale of this PR

  1. hardcode genesis codec version to codecv0.
  2. update codecv1 to latest version, synced from scroll repo.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

@0xmountaintop
Copy link
Member

bump version

@colinlyguo colinlyguo added the bug Something isn't working label Apr 13, 2024
@colinlyguo colinlyguo changed the title fix(rollup-verifier): update codecv1 fix(rollup-verifier): hardcode genesis codec version as codecv0 and sync codecv1 implementation Apr 13, 2024
@colinlyguo
Copy link
Member Author

bump version

done. will go to one of env2 to test.

@Thegaram Thegaram merged commit 5115f13 into develop Apr 16, 2024
7 checks passed
@Thegaram Thegaram deleted the update-codecv1 branch April 16, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants