forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more state_transition, worker, and tracing metrics #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinlyguo
previously approved these changes
Apr 15, 2024
omerfirmak
force-pushed
the
feat/add_metrics_of_worker
branch
from
April 15, 2024 12:23
f9590be
to
380327e
Compare
omerfirmak
previously approved these changes
Apr 15, 2024
Thegaram
previously approved these changes
Apr 15, 2024
Thegaram
changed the title
(worker):add metrics of worker
feat(worker): add more state_transition, worker, and tracing metrics
Apr 15, 2024
Thegaram
changed the title
feat(worker): add more state_transition, worker, and tracing metrics
feat: add more state_transition, worker, and tracing metrics
Apr 15, 2024
HAOYUatHZ
previously approved these changes
Apr 16, 2024
colinlyguo
previously approved these changes
Apr 16, 2024
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
…o-ethereum into feat/add_metrics_of_worker
colinlyguo
previously approved these changes
Apr 16, 2024
HAOYUatHZ
previously approved these changes
Apr 16, 2024
probably also need to bump version |
github-actions
bot
dismissed stale reviews from HAOYUatHZ and colinlyguo
via
April 16, 2024 07:49
fcec6b3
@HAOYUatHZ we found two small problems in the bump version bot: (i) will bump patch version in each commit without comparing the develop branch. (ii) unverified commit, thus stuck the CI. |
This reverts commit 175d544.
colinlyguo
approved these changes
Apr 16, 2024
HAOYUatHZ
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
getBlockTrace cost: 149ms
ccc applyTransaction: 295 ms
total cost : 4.5s
4500/(149+295+1) = 10
namely,
commitTransactions
parameter txs contains 10 tx, I think almost the real data. So if we can optimize this two function, the CommitTransactions performance will improvedCurrently, the
commitTransactions
all cost atgetBlockTrace
andccc applyTransaction
.This pr add metrics to investigate the cost of
getBlockTrace
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?