chore(libzkp): upgrade to v0.10.5, speed up by avoiding some unnecessary code hashing #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispc
changed the title
HAOYUatHZ
approved these changes
May 11, 2024
georgehao
approved these changes
May 11, 2024
Thegaram
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since code_size is stored inside the Account struct, we can use it instead of reading full bytecode.
CCC avg time(rust only) of recent blocks:
before this: deserialize_elapsed: 144.32ms, total_elapsed: 599.72ms
after this: deserialize_elapsed: 143.04ms, total_elapsed: 357.58ms
original commit: scroll-tech/zkevm-circuits@30ed394