Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): refactor some chainConfig #754

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Conversation

0xmountaintop
Copy link
Member

@0xmountaintop 0xmountaintop commented May 15, 2024

1. Purpose or design rationale of this PR

refactor some chainConfig, to make the code style consistent with other places and make it more readable.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop changed the title Refactor-genesis refactor(config): refactor some chainConfig May 15, 2024
colinlyguo
colinlyguo previously approved these changes May 16, 2024
Copy link
Member

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thegaram
Thegaram previously approved these changes May 28, 2024
params/config.go Show resolved Hide resolved
@0xmountaintop 0xmountaintop dismissed stale reviews from colinlyguo and Thegaram via 3884561 June 1, 2024 09:26
@georgehao georgehao merged commit 6229ef1 into develop Jun 5, 2024
8 checks passed
@georgehao georgehao deleted the refactor-genesis branch June 5, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants