Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid accidentally sharing a tracer between goroutines #768

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented May 23, 2024

1. Purpose or design rationale of this PR

All tests in scroll_worker_test.go instantiate a BlockChain with a tracer and debugging mode enabled. Pipeline used to share the vmConfig with BlockChain, which ended up multiple EVM instances to accidentally share a logger instance as well.

This is only relevant for tests, in normal mode of operation this is not an issue.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

0xmountaintop
0xmountaintop previously approved these changes May 24, 2024
@omerfirmak omerfirmak merged commit d086022 into develop Jun 5, 2024
8 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/sanitize-vm-config branch June 5, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants