Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update l1 db entry for curie transition block #835

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

Thegaram
Copy link

@Thegaram Thegaram commented Jun 18, 2024

1. Purpose or design rationale of this PR

Cherry-pick the fix from #789 on top of scroll-v5.4.4.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@omerfirmak
Copy link

PLEASE DO NOT bump version

why is that?

omerfirmak
omerfirmak previously approved these changes Jun 20, 2024
HAOYUatHZ
HAOYUatHZ previously approved these changes Jun 20, 2024
@github-actions github-actions bot dismissed stale reviews from HAOYUatHZ and omerfirmak via e9aa188 June 20, 2024 11:57
@omerfirmak omerfirmak merged commit c003520 into develop Jun 20, 2024
@omerfirmak omerfirmak deleted the feat-scroll-v5.4.4-fix branch June 20, 2024 12:00
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants